SSH increments should not be applied when using the linear free surface
Bug reported by Gurvan and fix provided by Mike Bell.
Context
- Branches impacted: branch_5.0, main
Analysis
When (ln_sshinc .AND. lk_linssh) == .TRUE.
, assimilation increments are applied to temperature and salinity in trasbc.F90
.
With the linear free surface, the volume of the cells does not vary as the free surface moves up and down, so no increments to the tracer fields are needed to maintain the tracer values in cells as their volume changes.
Fix
Do not apply increments in the linear free surface case (i.e. remove the code block associated with lk_linssh = .true.
in trasbc.F90
).