Nemo merge requestshttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests2023-12-11T11:40:36Zhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/376Merge branch 'cherry-pick-17646f45' into 'main'2023-12-11T11:40:36ZGuillaume SamsonMerge branch 'cherry-pick-17646f45' into 'main'Merge branch 'asm_flags_hardcoded' into 'main'
See merge request nemo/nemo!367
(cherry picked from commit 8ae69514b8448844f84796d755f7fb8936cdfb7e)
828c9a04 Merge branch 'flags_hard_coded' into 'branch_4.2_moi'Merge branch 'asm_flags_hardcoded' into 'main'
See merge request nemo/nemo!367
(cherry picked from commit 8ae69514b8448844f84796d755f7fb8936cdfb7e)
828c9a04 Merge branch 'flags_hard_coded' into 'branch_4.2_moi'2023 WPGuillaume SamsonGuillaume Samsonhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/194Resolve "OBS and ASM developments (2022 WP)"2023-12-07T13:18:06ZDavid FordResolve "OBS and ASM developments (2022 WP)"#### Tests
Once the development is done, the PI should complete the tests section below and after ask the reviewers to start their review.
This part should contain the detailed results of ~SETTE tests (restartability and reproducibili...#### Tests
Once the development is done, the PI should complete the tests section below and after ask the reviewers to start their review.
This part should contain the detailed results of ~SETTE tests (restartability and reproducibility for each of the reference configuration) and detailed results of restartability and reproducibility when the option is activated on specified configurations used for this test.
**Regular checks**
- [x] Can this change be shown to produce expected impact (option activated)?
- [x] Can this change be shown to have a null impact (option not activated)?
- [x] Results of the required bit comparability tests been run: are there no differences when activating the development?
- [ ] If some differences appear, is reason for the change valid/understood?
- [ ] If some differences appear, is the impact as expected on model configurations?
- [x] Is this change expected to preserve all diagnostics?
- [ ] If no, is reason for the change valid/understood?
- [ ] Are there significant changes in run time/memory?
#### Review
A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November).
**Assessments**
- [x] Is the proposed methodology now implemented?
- [x] Are the code changes in agreement with the flowchart defined at preview step?
- [x] Are the code changes in agreement with list of routines and variables as proposed at preview step?
- [ ] If, not, are the discrepancies acceptable?
- [x] Is the in-line documentation accurate and sufficient?
- [x] Do the code changes comply with NEMO coding standards?
- [x] Is the development documented with sufficient details for others to understand the impact of the change?
- [ ] Is the project ~doc (manual, guide, web, ...) now updated or completed following the proposed summary in preview section?
Closes #126; closes #270; closes #3102022 WPDavid FordDavid Fordhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/416Resolve "Coherent north-pole folding of velocity assimilation increments" ('m...2023-12-05T18:35:49ZSimon MuellerResolve "Coherent north-pole folding of velocity assimilation increments" ('main')Closes #340; closes #60Closes #340; closes #602023 OBS and ASM evolutionSimon MuellerSimon Muellerhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/415Resolve "Coherent north-pole folding of velocity assimilation increments"2023-12-05T18:33:01ZSimon MuellerResolve "Coherent north-pole folding of velocity assimilation increments"Update associated with #340Update associated with #3402023 OBS and ASM evolutionSimon MuellerSimon Muellerhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/367Merge branch 'asm_flags_hardcoded' into 'branch_4.2'2023-11-24T19:10:50ZGuillaume SamsonMerge branch 'asm_flags_hardcoded' into 'branch_4.2'Two flags (ln_seaiceinc and ln_temnofreeze) are hard-coded in ASM increment routine while they should be available in namelist.
See merge request devs/moi/nemoi!12
(cherry picked from commit 17646f45f29b53e003ab69b2f9ccce747dc7bb2f)
2...Two flags (ln_seaiceinc and ln_temnofreeze) are hard-coded in ASM increment routine while they should be available in namelist.
See merge request devs/moi/nemoi!12
(cherry picked from commit 17646f45f29b53e003ab69b2f9ccce747dc7bb2f)
2358bcce Two flags are hard-coded that is definitively not a good idea.Tag 4.2.2Guillaume SamsonGuillaume Samsonhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/192Resolve "Enhanced robustness of the SETTE namelist-file customization"2023-03-15T11:59:18ZSimon MuellerResolve "Enhanced robustness of the SETTE namelist-file customization"Closes #125Closes #125Tag 4.2.1Simon MuellerSimon Muellerhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/196Resolve "Generic configuration coverage in SETTE test reports"2023-03-15T11:58:47ZSimon MuellerResolve "Generic configuration coverage in SETTE test reports"Closes #127Closes #127Tag 4.2.1Simon MuellerSimon Muellerhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/193Merge branch '125-enhanced-robustness-of-the-sette-namelist-file-customizatio...2022-12-02T10:25:53ZSimon MuellerMerge branch '125-enhanced-robustness-of-the-sette-namelist-file-customization' into 'main'Resolve "Enhanced robustness of the SETTE namelist-file customization"
See merge request nemo/nemo!192
(cherry picked from commit 70d2d831f6d31d5a6fc1783a6d0eb447fdb17774)
eb3dc12b Enhanced namelist-record detection for the SETTE name...Resolve "Enhanced robustness of the SETTE namelist-file customization"
See merge request nemo/nemo!192
(cherry picked from commit 70d2d831f6d31d5a6fc1783a6d0eb447fdb17774)
eb3dc12b Enhanced namelist-record detection for the SETTE namelist-file customizing...2022 WPSimon MuellerSimon Muellerhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/197Resolve "Generic configuration coverage in SETTE test reports" ('main')2022-12-02T09:04:44ZSimon MuellerResolve "Generic configuration coverage in SETTE test reports" ('main')Closes #127Closes #1272022 WPSimon MuellerSimon Mueller