Nemo merge requestshttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests2024-02-29T17:37:59Zhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/466Resolve "Another bespoke collection of bug fixes"2024-02-29T17:37:59ZDaley CalvertResolve "Another bespoke collection of bug fixes"Closes #379.
#### Tests
**Regular checks**
SETTE passes, but it would not cover the issues addressed here as it does not test diagnostics and because RK3 is disabled.
**Other testing**
Testing was performed using 10-day runs of ORCA...Closes #379.
#### Tests
**Regular checks**
SETTE passes, but it would not cover the issues addressed here as it does not test diagnostics and because RK3 is disabled.
**Other testing**
Testing was performed using 10-day runs of ORCA2_ICE_PISCES with sea ice and passive tracers turned off.
The fixes change several diagnostic results, but only 12e1100b changes the model solution (when using `ln_zad_Aimp`).
#### Review
**Assessments**
- [ ] Is the proposed methodology now implemented?
- [ ] Are the code changes in agreement with the flowchart defined at preview step?
- [ ] Are the code changes in agreement with list of routines and variables as proposed at preview step?
- [ ] If, not, are the discrepancies acceptable?
- [ ] Is the in-line documentation accurate and sufficient?
- [ ] Do the code changes comply with NEMO coding standards?
- [ ] Is the development documented with sufficient details for others to understand the impact of the change?
- [ ] Is the project ~doc (manual, guide, web, ...) now updated or completed following the proposed summary in preview section?NEMO 5.0-betaDaley CalvertDaley Calverthttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/460Resolve "Compatibility of diagnostic model output and the tiling option"2024-02-06T11:53:27ZSimon MuellerResolve "Compatibility of diagnostic model output and the tiling option"Closes #375Closes #375NEMO 5.0-betaSimon MuellerSimon Muellerhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/330Resolve "&nam_diadct ! transports through some sections?"2023-06-16T12:31:59ZGuillaume SamsonResolve "&nam_diadct ! transports through some sections?"Closes #207Closes #207Tag 4.2.1Guillaume SamsonGuillaume Samsonhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/301Resolve several diagnostic issues in branch_4.22023-05-16T16:27:34ZDaley CalvertResolve several diagnostic issues in branch_4.2Closes #243
#### Tests
Once the development is done, the PI should complete the tests section below and after ask the reviewers to start their review.
This part should contain the detailed results of ~SETTE tests (restartability and ...Closes #243
#### Tests
Once the development is done, the PI should complete the tests section below and after ask the reviewers to start their review.
This part should contain the detailed results of ~SETTE tests (restartability and reproducibility for each of the reference configuration) and detailed results of restartability and reproducibility when the option is activated on specified configurations used for this test.
**Regular checks**
- [x] Can this change be shown to produce expected impact (option activated)?
- [x] Can this change be shown to have a null impact (option not activated)?
- [x] Results of the required bit comparability tests been run: are there no differences when activating the development?
- [ ] ~~If some differences appear, is reason for the change valid/understood?~~
- [ ] ~~If some differences appear, is the impact as expected on model configurations?~~
- [ ] Is this change expected to preserve all diagnostics?
- [x] If no, is reason for the change valid/understood?
- Some diagnostics were giving different results with the tiling active- these changes address this
- [ ] Are there significant changes in run time/memory?
#### Review
A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November).
**Assessments**
- [ ] Is the proposed methodology now implemented?
- [ ] Are the code changes in agreement with the flowchart defined at preview step?
- [ ] Are the code changes in agreement with list of routines and variables as proposed at preview step?
- [ ] If, not, are the discrepancies acceptable?
- [ ] Is the in-line documentation accurate and sufficient?
- [ ] Do the code changes comply with NEMO coding standards?
- [ ] Is the development documented with sufficient details for others to understand the impact of the change?
- [ ] Is the project ~doc (manual, guide, web, ...) now updated or completed following the proposed summary in preview section?Tag 4.2.1Daley CalvertDaley Calverthttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/299diadct mfo/sfo/hfo transports through sections via xios2023-05-26T15:40:15ZSarah Berthetdiadct mfo/sfo/hfo transports through sections via xiosMerge branch '207-nam_diadct-transports-through-some-sections' into 'branch_4.2'
Closes #207Merge branch '207-nam_diadct-transports-through-some-sections' into 'branch_4.2'
Closes #207Tag 4.2.1Sarah BerthetSarah Berthethttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/288Resolve "Error in `dia_hth_dep` when calculating 26/28 deg isotherm depth" ('...2023-05-05T10:49:13ZSimon MuellerResolve "Error in `dia_hth_dep` when calculating 26/28 deg isotherm depth" ('branch_4.2')Closes #175Closes #175Tag 4.2.1Simon MuellerSimon Muellerhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/285Resolve "Advective transport diagnostics are incorrect when using certain tra...2023-05-05T08:55:00ZDaley CalvertResolve "Advective transport diagnostics are incorrect when using certain tracer advection schemes"#### Tests
Once the development is done, the PI should complete the tests section below and after ask the reviewers to start their review.
This part should contain the detailed results of ~SETTE tests (restartability and reproducibili...#### Tests
Once the development is done, the PI should complete the tests section below and after ask the reviewers to start their review.
This part should contain the detailed results of ~SETTE tests (restartability and reproducibility for each of the reference configuration) and detailed results of restartability and reproducibility when the option is activated on specified configurations used for this test.
**Regular checks**
- [x] Can this change be shown to produce expected impact (option activated)?
- [x] Can this change be shown to have a null impact (option not activated)?
- [x] Results of the required bit comparability tests been run: are there no differences when activating the development?
- [ ] ~~If some differences appear, is reason for the change valid/understood?~~
- [ ] ~~If some differences appear, is the impact as expected on model configurations?~~
- [ ] Is this change expected to preserve all diagnostics?
- [x] If no, is reason for the change valid/understood?
- The diagnostics listed by #235 will have changed- they were incorrect before
- The new diagnostic values have been validated by comparing them to a reference code where similar workarounds to those utilised in `tra_ldf_iso` and `tra_ldf_lev` were applied to `tra_adv_cen` and `tra_adv_mus`
- [ ] Are there significant changes in run time/memory?
#### Review
A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November).
**Assessments**
- [ ] Is the proposed methodology now implemented?
- [ ] Are the code changes in agreement with the flowchart defined at preview step?
- [ ] Are the code changes in agreement with list of routines and variables as proposed at preview step?
- [ ] If, not, are the discrepancies acceptable?
- [ ] Is the in-line documentation accurate and sufficient?
- [ ] Do the code changes comply with NEMO coding standards?
- [ ] Is the development documented with sufficient details for others to understand the impact of the change?
- [ ] Is the project ~doc (manual, guide, web, ...) now updated or completed following the proposed summary in preview section?
Closes #235Tag 4.2.1Daley CalvertDaley Calverthttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/255Draft: Resolve "Error in `dia_hth_dep` when calculating 26/28 deg isotherm de...2023-05-04T11:22:05ZDaley CalvertDraft: Resolve "Error in `dia_hth_dep` when calculating 26/28 deg isotherm depth"Closes #175Closes #175Tag 4.2.1Daley CalvertDaley Calverthttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/238Resolve "Tiling of DIA subroutines"2023-03-15T14:00:20ZJonas GandertonResolve "Tiling of DIA subroutines"Added tiling to the DIA subroutines.\
Includes expansion of `GLOBSUM`/`LOCALSUM` in `lib_fortran_generic.h90` to:
- Operate on tile sized arrays
- Add to an existing sum
Closes #77 \
@dcalvertAdded tiling to the DIA subroutines.\
Includes expansion of `GLOBSUM`/`LOCALSUM` in `lib_fortran_generic.h90` to:
- Operate on tile sized arrays
- Add to an existing sum
Closes #77 \
@dcalvert2023 WPJonas GandertonJonas Gandertonhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/140Resolve "bug in the outputs from dia_ar5_hst"2023-03-15T12:00:39ZClement RoussetResolve "bug in the outputs from dia_ar5_hst"Closes #92Closes #92Tag 4.2.1Clement RoussetClement Roussethttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/122Draft: Resolve "Tiling for DIA code"2022-08-31T11:40:02ZJonas GandertonDraft: Resolve "Tiling for DIA code"#### Tests
Once the development is done, the PI should complete the tests section below and after ask the reviewers to start their review.
This part should contain the detailed results of ~SETTE tests (restartability and reproducibili...#### Tests
Once the development is done, the PI should complete the tests section below and after ask the reviewers to start their review.
This part should contain the detailed results of ~SETTE tests (restartability and reproducibility for each of the reference configuration) and detailed results of restartability and reproducibility when the option is activated on specified configurations used for this test.
**Regular checks**
- [ ] Can this change be shown to produce expected impact (option activated)?
- [ ] Can this change be shown to have a null impact (option not activated)?
- [ ] Results of the required bit comparability tests been run: are there no differences when activating the development?
- [ ] If some differences appear, is reason for the change valid/understood?
- [ ] If some differences appear, is the impact as expected on model configurations?
- [ ] Is this change expected to preserve all diagnostics?
- [ ] If no, is reason for the change valid/understood?
- [ ] Are there significant changes in run time/memory?
#### Review
A successful review is needed to schedule the merge of this development into the future NEMO release during next Merge Party (usually in November).
**Assessments**
- [ ] Is the proposed methodology now implemented?
- [ ] Are the code changes in agreement with the flowchart defined at preview step?
- [ ] Are the code changes in agreement with list of routines and variables as proposed at preview step?
- [ ] If, not, are the discrepancies acceptable?
- [ ] Is the in-line documentation accurate and sufficient?
- [ ] Do the code changes comply with NEMO coding standards?
- [ ] Is the development documented with sufficient details for others to understand the impact of the change?
- [ ] Is the project ~doc (manual, guide, web, ...) now updated or completed following the proposed summary in preview section?2022 WPJonas GandertonJonas Gandertonhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/108dev_2021_rk3_halo into 68-summer-body-20222022-06-28T09:06:17ZSebastien Massondev_2021_rk3_halo into 68-summer-body-2022linked to #68linked to #682022 WPSebastien MassonSebastien Massonhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/74nice bugfix in diaar5, #392023-03-15T11:59:53ZSebastien Massonnice bugfix in diaar5, #39(cherry picked from commit f5df5f58d93224f222bb3d2557bab987179b27a1)(cherry picked from commit f5df5f58d93224f222bb3d2557bab987179b27a1)Tag 4.2.1Sebastien MassonSebastien Massonhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/73Resolve "diaar5: Suspicious use of INTEGER in the ocean Volume computation"2022-04-22T07:25:55ZSebastien MassonResolve "diaar5: Suspicious use of INTEGER in the ocean Volume computation"Closes #39Closes #392022 WPSebastien MassonSebastien Massonhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/62Resolve "fix 3 minors issues"2023-03-15T11:59:30ZSebastien MassonResolve "fix 3 minors issues"Closes #36Closes #36Tag 4.2.1Sebastien MassonSebastien Massonhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/61Resolve "fix 3 minors issues"2022-04-01T16:44:56ZSebastien MassonResolve "fix 3 minors issues"Closes #36Closes #362022 WPSebastien MassonSebastien Massonhttps://forge.nemo-ocean.eu/nemo/nemo/-/merge_requests/23fix salt2c use2022-02-07T15:17:16ZSibylle Techenefix salt2c useCloses #15Closes #15Release 4.2Sibylle TecheneSibylle Techene