Comprehensive explicit declaration of dummy-subroutine arguments

Context

The PSyclone development team has reported the presence of implicitly declared subroutine arguments in the pre-processed source-code files trcbdy.f90, trcdta.f90, and trcstp.f90 for the GYRE_PISCES reference configuration of the NEMO 4.2.0 release version without defined pre-processing key key_top. Implicitly declared subroutine arguments are not currently supported by the latest PSyclone release version (see PSyclone issue #1891) and are inconsistent with the NEMO Coding Rules (Sec. G.6.3 of the NEMO manual).

Analysis

Implicitly declared arguments are currently present in the dummy subroutines included in modules trcbdy, trcdta, trcstp, and trcstp_rk3 following the pre-processing of the TOP source code with deselected key key_top.

Fix

The explicit declaration of all dummy-subroutine arguments is recommended. Further, it is suggested to equip all TOP modules with the IMPLICIT NONE statement irrespective of whether the pre-processing key key_top is defined.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information