Skip to content

Tiling changes results with EIV

Context

  • Branches impacted: main (since 16443a0b)
  • Reference configuration/test case (chosen or used as template): ORCA2
  • Computing architecture: compiler, MPI & NetCDF libs (name and version)
  • Dependencies
    • ln_tile = .TRUE.
    • ln_ldfeiv = .TRUE.
    • Tracer advection schemes other than FCT
  • Any other relevant information

Analysis

A couple of non-overlapping DO loop macros (DO_3D_OVR) are still used by the ldf_eiv_trp subroutine in ldftra.F90. These should have been removed as part of #68 (closed).

The impact of this (and part of why these macros are being phased out) is that the tiling will give different results for this subroutine, since the DO loop bounds are inconsistent with those used to update the tendencies elsewhere in tra_adv (these use the normal DO_2D/DO_3D macros).

This was not picked up by SETTE because tiling is disabled in tra_adv when using the FCT advection scheme.

Fix

Replace DO_3D_OVR with DO_3D in ldf_eiv_trp.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information