Resolve "Various fixes on the main"
Closes #366 (closed).
Tests
Regular checks
-
Can this change be shown to produce expected impact (option activated)? -
Can this change be shown to have a null impact (option not activated)? -
Results of the required bit comparability tests been run: are there no differences when activating the development? -
Is this change expected to preserve all diagnostics? -
If no, is reason for the change valid/understood?
-
-
Are there significant changes in run time/memory?
SETTE was tested using MLF and not RK3.
Other testing
Other testing was performed using a 10-day run of ORCA2_ICE_PISCES with sea ice and passive tracers turned off (so just "ORCA2" I guess).
This testing checked for restartability in MLF and RK3 timestepping, as well as tiling reproducibility (whether using tiling changes the results) for MLF, by comparing run.stat
files and most available model diagnostics.
521044a4 and 3d6d7219 will change results due to the use of ldfull = .TRUE.
in lbc_lnk
calls. This is expected when fixing restartability issues.
Review
Assessments
-
Is the proposed methodology now implemented? -
Are the code changes in agreement with the flowchart defined at preview step? -
Are the code changes in agreement with list of routines and variables as proposed at preview step? -
If, not, are the discrepancies acceptable?
-
-
Is the in-line documentation accurate and sufficient? -
Do the code changes comply with NEMO coding standards? -
Is the development documented with sufficient details for others to understand the impact of the change? -
Is the project doc (manual, guide, web, ...) now updated or completed following the proposed summary in preview section?
Edited by Daley Calvert