Resolve "Another bespoke collection of bug fixes"
Closes #379 (closed).
Tests
Regular checks
SETTE passes, but it would not cover the issues addressed here as it does not test diagnostics and because RK3 is disabled.
Other testing
Testing was performed using 10-day runs of ORCA2_ICE_PISCES with sea ice and passive tracers turned off.
The fixes change several diagnostic results, but only 12e1100b changes the model solution (when using ln_zad_Aimp
).
Review
Assessments
-
Is the proposed methodology now implemented? -
Are the code changes in agreement with the flowchart defined at preview step? -
Are the code changes in agreement with list of routines and variables as proposed at preview step? -
If, not, are the discrepancies acceptable?
-
-
Is the in-line documentation accurate and sufficient? -
Do the code changes comply with NEMO coding standards? -
Is the development documented with sufficient details for others to understand the impact of the change? -
Is the project doc (manual, guide, web, ...) now updated or completed following the proposed summary in preview section?
Edited by Daley Calvert